mirror of
https://gitlab.archlinux.org/archlinux/aurweb.git
synced 2025-02-03 10:43:03 +01:00
[FastAPI] Refactor db modifications
For SQLAlchemy to automatically understand updates from the external world, it must use an `autocommit=True` in its session. This change breaks how we were using commit previously, as `autocommit=True` causes SQLAlchemy to commit when a SessionTransaction context hits __exit__. So, a refactoring was required of our tests: All usage of any `db.{create,delete}` must be called **within** a SessionTransaction context, created via new `db.begin()`. From this point forward, we're going to require: ``` with db.begin(): db.create(...) db.delete(...) db.session.delete(object) ``` With this, we now get external DB modifications automatically without reloading or restarting the FastAPI server, which we absolutely need for production. Signed-off-by: Kevin Morris <kevr@0cost.org>
This commit is contained in:
parent
b52059d437
commit
a5943bf2ad
37 changed files with 998 additions and 902 deletions
|
@ -2,7 +2,7 @@ import pytest
|
|||
|
||||
from sqlalchemy.exc import IntegrityError
|
||||
|
||||
from aurweb.db import create, query, rollback
|
||||
from aurweb.db import begin, create, query, rollback
|
||||
from aurweb.models.account_type import AccountType
|
||||
from aurweb.models.package import Package
|
||||
from aurweb.models.package_base import PackageBase
|
||||
|
@ -21,17 +21,19 @@ def setup():
|
|||
|
||||
account_type = query(AccountType,
|
||||
AccountType.AccountType == "User").first()
|
||||
user = create(User, Username="test", Email="test@example.org",
|
||||
RealName="Test User", Passwd="testPassword",
|
||||
AccountType=account_type)
|
||||
pkgbase = create(PackageBase,
|
||||
Name="test-package",
|
||||
Maintainer=user)
|
||||
package = create(Package, PackageBase=pkgbase, Name="test-package")
|
||||
with begin():
|
||||
user = create(User, Username="test", Email="test@example.org",
|
||||
RealName="Test User", Passwd="testPassword",
|
||||
AccountType=account_type)
|
||||
pkgbase = create(PackageBase,
|
||||
Name="test-package",
|
||||
Maintainer=user)
|
||||
package = create(Package, PackageBase=pkgbase, Name="test-package")
|
||||
|
||||
|
||||
def test_package_source():
|
||||
pkgsource = create(PackageSource, Package=package)
|
||||
with begin():
|
||||
pkgsource = create(PackageSource, Package=package)
|
||||
assert pkgsource.Package == package
|
||||
# By default, PackageSources.Source assigns the string '/dev/null'.
|
||||
assert pkgsource.Source == "/dev/null"
|
||||
|
@ -40,5 +42,6 @@ def test_package_source():
|
|||
|
||||
def test_package_source_null_package_raises_exception():
|
||||
with pytest.raises(IntegrityError):
|
||||
create(PackageSource)
|
||||
with begin():
|
||||
create(PackageSource)
|
||||
rollback()
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue