mirror of
https://gitlab.archlinux.org/archlinux/aurweb.git
synced 2025-02-03 10:43:03 +01:00
[FastAPI] Refactor db modifications
For SQLAlchemy to automatically understand updates from the external world, it must use an `autocommit=True` in its session. This change breaks how we were using commit previously, as `autocommit=True` causes SQLAlchemy to commit when a SessionTransaction context hits __exit__. So, a refactoring was required of our tests: All usage of any `db.{create,delete}` must be called **within** a SessionTransaction context, created via new `db.begin()`. From this point forward, we're going to require: ``` with db.begin(): db.create(...) db.delete(...) db.session.delete(object) ``` With this, we now get external DB modifications automatically without reloading or restarting the FastAPI server, which we absolutely need for production. Signed-off-by: Kevin Morris <kevr@0cost.org>
This commit is contained in:
parent
b52059d437
commit
a5943bf2ad
37 changed files with 998 additions and 902 deletions
|
@ -4,7 +4,7 @@ from unittest import mock
|
|||
|
||||
import pytest
|
||||
|
||||
from aurweb.db import create, query
|
||||
from aurweb import db
|
||||
from aurweb.models.account_type import AccountType
|
||||
from aurweb.models.session import Session, generate_unique_sid
|
||||
from aurweb.models.user import User
|
||||
|
@ -19,13 +19,16 @@ def setup():
|
|||
|
||||
setup_test_db("Users", "Sessions")
|
||||
|
||||
account_type = query(AccountType,
|
||||
AccountType.AccountType == "User").first()
|
||||
user = create(User, Username="test", Email="test@example.org",
|
||||
ResetKey="testReset", Passwd="testPassword",
|
||||
AccountType=account_type)
|
||||
session = create(Session, UsersID=user.ID, SessionID="testSession",
|
||||
LastUpdateTS=datetime.utcnow().timestamp())
|
||||
account_type = db.query(AccountType,
|
||||
AccountType.AccountType == "User").first()
|
||||
with db.begin():
|
||||
user = db.create(User, Username="test", Email="test@example.org",
|
||||
ResetKey="testReset", Passwd="testPassword",
|
||||
AccountType=account_type)
|
||||
|
||||
with db.begin():
|
||||
session = db.create(Session, UsersID=user.ID, SessionID="testSession",
|
||||
LastUpdateTS=datetime.utcnow().timestamp())
|
||||
|
||||
|
||||
def test_session():
|
||||
|
@ -35,12 +38,15 @@ def test_session():
|
|||
|
||||
def test_session_cs():
|
||||
""" Test case sensitivity of the database table. """
|
||||
user2 = create(User, Username="test2", Email="test2@example.org",
|
||||
ResetKey="testReset2", Passwd="testPassword",
|
||||
AccountType=account_type)
|
||||
session_cs = create(Session, UsersID=user2.ID,
|
||||
SessionID="TESTSESSION",
|
||||
LastUpdateTS=datetime.utcnow().timestamp())
|
||||
with db.begin():
|
||||
user2 = db.create(User, Username="test2", Email="test2@example.org",
|
||||
ResetKey="testReset2", Passwd="testPassword",
|
||||
AccountType=account_type)
|
||||
|
||||
with db.begin():
|
||||
session_cs = db.create(Session, UsersID=user2.ID,
|
||||
SessionID="TESTSESSION",
|
||||
LastUpdateTS=datetime.utcnow().timestamp())
|
||||
assert session_cs.SessionID == "TESTSESSION"
|
||||
assert session.SessionID == "testSession"
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue