Basic vertical rendering

- Add height attribute to most particles for height generation on the fly
This commit is contained in:
Kyle Gunger 2023-01-18 03:43:35 -05:00
parent 37b5b02fc4
commit 60c18246d8
23 changed files with 286 additions and 158 deletions

View file

@ -8,12 +8,15 @@
#include "../particle.h"
struct private {
int left_spacing;
int right_spacing;
int pre_spacing;
int post_spacing;
bool vertical;
struct exposable **exposables;
size_t count;
int *widths;
int *heights;
};
static void
@ -27,6 +30,7 @@ dynlist_destroy(struct exposable *exposable)
free(e->exposables);
free(e->widths);
free(e->heights);
free(e);
free(exposable);
}
@ -35,26 +39,41 @@ static int
dynlist_begin_expose(struct exposable *exposable)
{
const struct private *e = exposable->private;
exposable->width = 0;
exposable->height = 0;
bool have_at_least_one = false;
for (size_t i = 0; i < e->count; i++) {
struct exposable *ee = e->exposables[i];
e->widths[i] = ee->begin_expose(ee);
ee->begin_expose(ee);
e->widths[i] = ee->width;
e->heights[i] = ee->height;
assert(e->widths[i] >= 0);
assert(e->widths[i] >= 0 && e->heights[i] >= 0);
if (e->widths[i] > 0) {
exposable->width += e->left_spacing + e->widths[i] + e->right_spacing;
if (e->widths[i] > 0 && e->heights[i] > 0) {
if (e->vertical) {
exposable->height += e->pre_spacing + e->heights[i] + e->post_spacing;
if (e->widths[i] > exposable->width)
exposable->width = e->widths[i];
} else {
exposable->width += e->pre_spacing + e->widths[i] + e->post_spacing;
if (e->heights[i] > exposable->height)
exposable->height = e->heights[i];
}
have_at_least_one = true;
}
}
if (have_at_least_one)
exposable->width -= e->left_spacing + e->right_spacing;
if (have_at_least_one) {
if (e->vertical)
exposable->height -= e->pre_spacing + e->post_spacing;
else
exposable->width -= e->pre_spacing + e->post_spacing;
}
else
assert(exposable->width == 0);
assert(exposable->width == 0 || exposable->height == 0);
return exposable->width;
}
@ -63,15 +82,25 @@ dynlist_expose(const struct exposable *exposable, pixman_image_t *pix, int x, in
{
const struct private *e = exposable->private;
int left_spacing = e->left_spacing;
int right_spacing = e->right_spacing;
int pre_spacing = e->pre_spacing;
int post_spacing = e->post_spacing;
x -= left_spacing;
if (e->vertical) {
y -= pre_spacing;
for (size_t i = 0; i < e->count; i++) {
const struct exposable *ee = e->exposables[i];
ee->expose(ee, pix, x + left_spacing, y, height);
x += left_spacing + e->widths[i] + right_spacing;
for (size_t i = 0; i < e->count; i++) {
const struct exposable *ee = e->exposables[i];
ee->expose(ee, pix, x, y + pre_spacing, height);
y += pre_spacing + e->heights[i] + post_spacing;
}
} else {
x -= pre_spacing;
for (size_t i = 0; i < e->count; i++) {
const struct exposable *ee = e->exposables[i];
ee->expose(ee, pix, x + pre_spacing, y, height);
x += pre_spacing + e->widths[i] + post_spacing;
}
}
}
@ -96,7 +125,7 @@ on_mouse(struct exposable *exposable, struct bar *bar,
return;
}
px += e->left_spacing + e->exposables[i]->width + e->right_spacing;
px += e->pre_spacing + e->exposables[i]->width + e->post_spacing;
}
LOG_DBG("on_mouse missed all sub-particles");
@ -104,15 +133,17 @@ on_mouse(struct exposable *exposable, struct bar *bar,
}
struct exposable *
dynlist_exposable_new(struct exposable **exposables, size_t count,
int left_spacing, int right_spacing)
dynlist_exposable_new(struct exposable **exposables, size_t count, bool vertical,
int pre_spacing, int post_spacing)
{
struct private *e = calloc(1, sizeof(*e));
e->count = count;
e->vertical = vertical;
e->exposables = malloc(count * sizeof(e->exposables[0]));
e->widths = calloc(count, sizeof(e->widths[0]));
e->left_spacing = left_spacing;
e->right_spacing = right_spacing;
e->heights = calloc(count, sizeof(e->heights[0]));
e->pre_spacing = pre_spacing;
e->post_spacing = post_spacing;
for (size_t i = 0; i < count; i++)
e->exposables[i] = exposables[i];

View file

@ -1,7 +1,8 @@
#pragma once
#include <stddef.h>
#include <stdbool.h>
struct particle;
struct exposable *dynlist_exposable_new(
struct exposable **exposables, size_t count, int left_spacing, int right_spacing);
struct exposable **exposables, size_t count, bool vertical, int pre_spacing, int post_spacing);

View file

@ -10,13 +10,15 @@ begin_expose(struct exposable *exposable)
{
exposable->width = exposable->particle->left_margin +
exposable->particle->right_margin;
exposable->height = exposable->particle->top_margin +
exposable->particle->bottom_margin;
return exposable->width;
}
static void
expose(const struct exposable *exposable, pixman_image_t *pix, int x, int y, int height)
{
exposable_render_deco(exposable, pix, x, y, height);
exposable_render_deco(exposable, pix, x, y);
}
static struct exposable *

View file

@ -1,4 +1,5 @@
#include <stdlib.h>
#include <stdbool.h>
#define LOG_MODULE "list"
#define LOG_ENABLE_DBG 0
@ -11,14 +12,17 @@
struct private {
struct particle **particles;
size_t count;
int left_spacing, right_spacing;
bool vertical;
int pre_spacing, post_spacing;
};
struct eprivate {
struct exposable **exposables;
int *widths;
int *heights;
bool vertical;
size_t count;
int left_spacing, right_spacing;
int pre_spacing, post_spacing;
};
@ -31,6 +35,7 @@ exposable_destroy(struct exposable *exposable)
free(e->exposables);
free(e->widths);
free(e->heights);
free(e);
exposable_default_destroy(exposable);
}
@ -42,25 +47,39 @@ begin_expose(struct exposable *exposable)
bool have_at_least_one = false;
exposable->width = 0;
exposable->height = 0;
for (size_t i = 0; i < e->count; i++) {
struct exposable *ee = e->exposables[i];
e->widths[i] = ee->begin_expose(ee);
ee->begin_expose(ee);
e->widths[i] = ee->width;
e->heights[i] = ee->height;
assert(e->widths[i] >= 0);
assert(e->widths[i] >= 0 && e->heights[i] >= 0);
if (e->widths[i] > 0) {
exposable->width += e->left_spacing + e->widths[i] + e->right_spacing;
if (e->widths[i] > 0 && e->heights[i] > 0) {
if (e->vertical) {
exposable->height += e->pre_spacing + e->heights[i] + e->post_spacing;
if (e->widths[i] > exposable->width)
exposable->width = e->widths[i];
} else {
exposable->width += e->pre_spacing + e->widths[i] + e->post_spacing;
if (e->heights[i] > exposable->height)
exposable->height = e->heights[i];
}
have_at_least_one = true;
}
}
if (have_at_least_one) {
exposable->width -= e->left_spacing + e->right_spacing;
exposable->width += exposable->particle->left_margin;
exposable->width += exposable->particle->right_margin;
if(e->vertical)
exposable->width -= e->pre_spacing + e->post_spacing;
else
exposable->height -= e->pre_spacing + e->post_spacing;
exposable->width += exposable->particle->left_margin + exposable->particle->right_margin;
exposable->height += exposable->particle->top_margin + exposable->particle->bottom_margin;
} else
assert(exposable->width == 0);
assert(exposable->width == 0 && exposable->height == 0);
return exposable->width;
}
@ -70,20 +89,31 @@ expose(const struct exposable *exposable, pixman_image_t *pix, int x, int y, int
{
const struct eprivate *e = exposable->private;
exposable_render_deco(exposable, pix, x, y, height);
exposable_render_deco(exposable, pix, x, y);
int left_margin = exposable->particle->left_margin;
int left_spacing = e->left_spacing;
int right_spacing = e->right_spacing;
int pre_spacing = e->pre_spacing;
int post_spacing = e->post_spacing;
x += exposable->particle->left_margin;
y += exposable->particle->top_margin;
x += left_margin - left_spacing;
for (size_t i = 0; i < e->count; i++) {
const struct exposable *ee = e->exposables[i];
ee->expose(ee, pix, x + left_spacing, y, height);
x += left_spacing + e->widths[i] + right_spacing;
if (e->vertical) {
y -= pre_spacing;
for (size_t i = 0; i < e->count; i++) {
const struct exposable *ee = e->exposables[i];
ee->expose(ee, pix, x, y + pre_spacing, height);
x += pre_spacing + e->heights[i] + post_spacing;
}
} else {
x -= pre_spacing;
for (size_t i = 0; i < e->count; i++) {
const struct exposable *ee = e->exposables[i];
ee->expose(ee, pix, x + pre_spacing, y, height);
x += pre_spacing + e->widths[i] + post_spacing;
}
}
}
// TODO: update for vertical lists
static void
on_mouse(struct exposable *exposable, struct bar *bar,
enum mouse_event event, enum mouse_button btn, int x, int y)
@ -110,7 +140,7 @@ on_mouse(struct exposable *exposable, struct bar *bar,
return;
}
px += e->left_spacing + e->exposables[i]->width + e->right_spacing;
px += e->pre_spacing + e->exposables[i]->width + e->post_spacing;
}
/* We're between sub-particles (or in the left/right margin) */
@ -125,9 +155,11 @@ instantiate(const struct particle *particle, const struct tag_set *tags)
struct eprivate *e = calloc(1, sizeof(*e));
e->exposables = malloc(p->count * sizeof(*e->exposables));
e->widths = calloc(p->count, sizeof(*e->widths));
e->heights = calloc(p->count, sizeof(*e->heights));
e->count = p->count;
e->left_spacing = p->left_spacing;
e->right_spacing = p->right_spacing;
e->vertical = p->vertical;
e->pre_spacing = p->pre_spacing;
e->post_spacing = p->post_spacing;
for (size_t i = 0; i < p->count; i++) {
const struct particle *pp = p->particles[i];
@ -158,13 +190,14 @@ particle_destroy(struct particle *particle)
struct particle *
particle_list_new(struct particle *common,
struct particle *particles[], size_t count,
int left_spacing, int right_spacing)
bool vertical, int pre_spacing, int post_spacing)
{
struct private *p = calloc(1, sizeof(*p));
p->particles = malloc(count * sizeof(p->particles[0]));
p->count = count;
p->left_spacing = left_spacing;
p->right_spacing = right_spacing;
p->vertical = vertical;
p->pre_spacing = pre_spacing;
p->post_spacing = post_spacing;
for (size_t i = 0; i < count; i++)
p->particles[i] = particles[i];
@ -180,13 +213,16 @@ from_conf(const struct yml_node *node, struct particle *common)
{
const struct yml_node *items = yml_get_value(node, "items");
const struct yml_node *spacing = yml_get_value(node, "spacing");
const struct yml_node *_left_spacing = yml_get_value(node, "left-spacing");
const struct yml_node *_right_spacing = yml_get_value(node, "right-spacing");
const struct yml_node *_pre_spacing = yml_get_value(node, "pre-spacing");
const struct yml_node *_post_spacing = yml_get_value(node, "post-spacing");
const struct yml_node *_vertical = yml_get_value(node, "vertical");
int left_spacing = spacing != NULL ? yml_value_as_int(spacing) :
_left_spacing != NULL ? yml_value_as_int(_left_spacing) : 0;
int right_spacing = spacing != NULL ? yml_value_as_int(spacing) :
_right_spacing != NULL ? yml_value_as_int(_right_spacing) : 2;
int pre_spacing = spacing != NULL ? yml_value_as_int(spacing) :
_pre_spacing != NULL ? yml_value_as_int(_pre_spacing) : 0;
int post_spacing = spacing != NULL ? yml_value_as_int(spacing) :
_post_spacing != NULL ? yml_value_as_int(_post_spacing) : 2;
bool vertical = _vertical != NULL ? yml_value_as_bool(_vertical) : false;
size_t count = yml_list_length(items);
struct particle *parts[count];
@ -200,7 +236,7 @@ from_conf(const struct yml_node *node, struct particle *common)
it.node, (struct conf_inherit){common->font, common->font_shaping, common->foreground});
}
return particle_list_new(common, parts, count, left_spacing, right_spacing);
return particle_list_new(common, parts, count, vertical, pre_spacing, post_spacing);
}
static bool

View file

@ -2,6 +2,7 @@
#include <string.h>
#include <errno.h>
#include <assert.h>
#include <stdbool.h>
#define LOG_MODULE "map"
#include "../log.h"
@ -184,13 +185,20 @@ begin_expose(struct exposable *exposable)
{
struct eprivate *e = exposable->private;
int width = e->exposable->begin_expose(e->exposable);
assert(width >= 0);
e->exposable->begin_expose(e->exposable);
int width = e->exposable->width;
int height = e->exposable->height;
assert(width >= 0 && height >= 0);
if (width > 0)
width += exposable->particle->left_margin + exposable->particle->right_margin;
if (height > 0)
height += exposable->particle->top_margin + exposable->particle->bottom_margin;
exposable->width = width;
exposable->height = height;
return exposable->width;
}
@ -199,7 +207,7 @@ expose(const struct exposable *exposable, pixman_image_t *pix, int x, int y, int
{
struct eprivate *e = exposable->private;
exposable_render_deco(exposable, pix, x, y, height);
exposable_render_deco(exposable, pix, x, y);
e->exposable->expose(
e->exposable, pix, x + exposable->particle->left_margin, y, height);
}
@ -254,7 +262,7 @@ instantiate(const struct particle *particle, const struct tag_set *tags)
else if (p->default_particle != NULL)
e->exposable = p->default_particle->instantiate(p->default_particle, tags);
else
e->exposable = dynlist_exposable_new(NULL, 0, 0, 0);
e->exposable = dynlist_exposable_new(NULL, 0, false, 0, 0);
assert(e->exposable != NULL);

View file

@ -87,7 +87,7 @@ expose(const struct exposable *exposable, pixman_image_t *pix, int x, int y, int
{
const struct eprivate *e = exposable->private;
exposable_render_deco(exposable, pix, x, y, height);
exposable_render_deco(exposable, pix, x, y);
x += exposable->particle->left_margin;
for (size_t i = 0; i < e->count; i++) {

View file

@ -41,13 +41,19 @@ begin_expose(struct exposable *exposable)
{
struct eprivate *e = exposable->private;
int width = e->exposable->begin_expose(e->exposable);
e->exposable->begin_expose(e->exposable);
int width = e->exposable->width;
int height = e->exposable->height;
assert(width >= 0);
if (width > 0)
width += exposable->particle->left_margin + exposable->particle->right_margin;
if (height > 0)
height += exposable->particle->top_margin + exposable->particle->bottom_margin;
exposable->width = width;
exposable->height = height;
return exposable->width;
}
@ -56,7 +62,7 @@ expose(const struct exposable *exposable, pixman_image_t *pix, int x, int y, int
{
struct eprivate *e = exposable->private;
exposable_render_deco(exposable, pix, x, y, height);
exposable_render_deco(exposable, pix, x, y);
e->exposable->expose(
e->exposable, pix, x + exposable->particle->left_margin, y, height);
}

View file

@ -15,6 +15,7 @@ struct text_run_cache {
uint64_t hash;
struct fcft_text_run *run;
int width;
int height;
bool in_use;
};
@ -31,6 +32,7 @@ struct eprivate {
const struct fcft_glyph **glyphs;
const struct fcft_glyph **allocated_glyphs;
long *kern_x;
long *kern_y;
int num_glyphs;
};
@ -41,6 +43,7 @@ exposable_destroy(struct exposable *exposable)
free(e->allocated_glyphs);
free(e->kern_x);
free(e->kern_y);
free(e);
exposable_default_destroy(exposable);
}
@ -50,26 +53,32 @@ begin_expose(struct exposable *exposable)
{
struct eprivate *e = exposable->private;
struct private *p = exposable->particle->private;
const struct fcft_font *font = exposable->particle->font;
exposable->width =
exposable->particle->left_margin +
exposable->particle->right_margin;
exposable->height =
exposable->particle->top_margin +
exposable->particle->bottom_margin;
exposable->height += font->ascent + font->descent;
if (e->cache_idx >= 0) {
exposable->width += p->cache[e->cache_idx].width;
} else {
/* Calculate the size we need to render the glyphs */
for (int i = 0; i < e->num_glyphs; i++)
for (int i = 0; i < e->num_glyphs; i++) {
exposable->width += e->kern_x[i] + e->glyphs[i]->advance.x;
}
}
LOG_INFO("String height: %d", exposable->height);
return exposable->width;
}
static void
expose(const struct exposable *exposable, pixman_image_t *pix, int x, int y, int height)
{
exposable_render_deco(exposable, pix, x, y, height);
exposable_render_deco(exposable, pix, x, y);
const struct eprivate *e = exposable->private;
const struct fcft_font *font = exposable->particle->font;
@ -97,8 +106,9 @@ expose(const struct exposable *exposable, pixman_image_t *pix, int x, int y, int
* any real facts, but works very well with e.g. the "Awesome 6"
* font family.
*/
// TODO: FIX THIS
const double baseline = (double)y +
(double)(height + font->ascent + font->descent) / 2.0 -
(double)(exposable->height + font->ascent + font->descent) / 2.0 -
(font->descent > 0 ? font->descent : 0);
x += exposable->particle->left_margin;
@ -109,6 +119,7 @@ expose(const struct exposable *exposable, pixman_image_t *pix, int x, int y, int
assert(glyph != NULL);
x += e->kern_x[i];
y += e->kern_y[i];
if (pixman_image_get_format(glyph->pix) == PIXMAN_a8r8g8b8) {
/* Glyph surface is a pre-rendered image (typically a color emoji...) */
@ -156,6 +167,7 @@ instantiate(const struct particle *particle, const struct tag_set *tags)
e->glyphs = e->allocated_glyphs = NULL;
e->num_glyphs = 0;
e->kern_x = NULL;
e->kern_y = NULL;
e->cache_idx = -1;
uint64_t hash = sdbm_hash(text);
@ -170,6 +182,7 @@ instantiate(const struct particle *particle, const struct tag_set *tags)
e->glyphs = p->cache[i].run->glyphs;
e->num_glyphs = p->cache[i].run->count;
e->kern_x = calloc(p->cache[i].run->count, sizeof(e->kern_x[0]));
e->kern_y = calloc(p->cache[i].run->count, sizeof(e->kern_y[0]));
goto done;
}
}
@ -197,6 +210,7 @@ instantiate(const struct particle *particle, const struct tag_set *tags)
}
e->kern_x = calloc(chars, sizeof(e->kern_x[0]));
e->kern_y = calloc(chars, sizeof(e->kern_y[0]));
if (particle->font_shaping == FONT_SHAPE_FULL &&
fcft_capabilities() & FCFT_CAPABILITY_TEXT_RUN_SHAPING)
@ -205,9 +219,11 @@ instantiate(const struct particle *particle, const struct tag_set *tags)
font, chars, wtext, FCFT_SUBPIXEL_NONE);
if (run != NULL) {
int w = 0;
for (size_t i = 0; i < run->count; i++)
int w = 0, h = 0;
for (size_t i = 0; i < run->count; i++) {
w += run->glyphs[i]->advance.x;
h += run->glyphs[i]->advance.y;
}
ssize_t cache_idx = -1;
for (size_t i = 0; i < p->cache_size; i++) {
@ -232,6 +248,7 @@ instantiate(const struct particle *particle, const struct tag_set *tags)
p->cache[cache_idx].hash = hash;
p->cache[cache_idx].run = run;
p->cache[cache_idx].width = w;
p->cache[cache_idx].height = h;
p->cache[cache_idx].in_use = true;
e->cache_idx = cache_idx;
@ -256,7 +273,7 @@ instantiate(const struct particle *particle, const struct tag_set *tags)
if (i == 0)
continue;
fcft_kerning(font, wtext[i - 1], wtext[i], &e->kern_x[i], NULL);
fcft_kerning(font, wtext[i - 1], wtext[i], &e->kern_x[i], &e->kern_y[i]);
}
e->glyphs = e->allocated_glyphs;