From b0e384b2f3304e3f63b2d6c2f62af365233b1466 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Ekl=C3=B6f?= Date: Tue, 15 Jan 2019 19:18:01 +0100 Subject: [PATCH] module/xwindow: don't crash if window doesn't have a correctly sized PID property --- modules/xwindow.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/modules/xwindow.c b/modules/xwindow.c index f56f31e..c6a6fe3 100644 --- a/modules/xwindow.c +++ b/modules/xwindow.c @@ -99,7 +99,10 @@ update_application(struct module *mod) } uint32_t pid; - assert(xcb_get_property_value_length(r) == sizeof(pid)); + if (xcb_get_property_value_length(r) != sizeof(pid)) { + free(r); + return; + } memcpy(&pid, xcb_get_property_value(r), sizeof(pid)); free(r);